From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4B38C355.3090306@domain.hid> Date: Mon, 28 Dec 2009 15:40:21 +0100 From: Gilles Chanteperdrix MIME-Version: 1.0 References: <1261560352-9120-1-git-send-email-wolfgang.mauerer@domain.hid> <1261560352-9120-3-git-send-email-wolfgang.mauerer@domain.hid> <4B31E503.8030208@domain.hid> <4B31EADB.8040305@domain.hid> <4B31EB70.3090108@domain.hid> In-Reply-To: <4B31EB70.3090108@domain.hid> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Xenomai-core] [PATCH 2/2] Testcase for the xnvdso mechanism List-Id: Xenomai life and development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wolfgang Mauerer Cc: "Kiszka, Jan" , "xenomai@xenomai.org" Gilles Chanteperdrix wrote: > Wolfgang Mauerer wrote: >> Gilles Chanteperdrix wrote: >>> Wolfgang Mauerer wrote: >>>> This testcase checks if the value in xnvdso->features matches the >>>> value of XNVDSO_FEATURES, that is, if the information is correctly >>>> transferred from kernel to userland. >>>> >>>> Notice that the approach will fail once configurations are supported >>>> that know of multiple features and implement only some of them. >>>> In this case, the testcase needs to be extended accordingly >>>> to check that only the expected features are present. >>> Please allow to pass the value we want to check on the test command line. >> here you go. I suppose keeping XNVDSO_FEATURES as default value >> unless something different is specified is okay? > > Yes, ok. I am fine with the two patches. Ok. I merged them, but renamed a bit the symbols to get things more in line with what we do usually. xnvdso is the struct nkvdso is the global variable the xnsysinfo_t member is now simply vdso. -- Gilles.