From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Andi Kleen <andi@firstfloor.org>
Cc: Nitin Gupta <ngupta@vflare.org>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] [mmotm] Add notifiers for various swap events
Date: Mon, 28 Dec 2009 20:43:14 +0200 [thread overview]
Message-ID: <4B38FC42.7000204@cs.helsinki.fi> (raw)
In-Reply-To: <20091228172903.GF4994@basil.fritz.box>
Hi Andi,
Andi Kleen wrote:
>>> The first question to ask is if compressed swap is worth
>>> it. Do you have benchmark numbers showing it to be an improvement?
>>> Are there cases where it is slower than uncompressed swap?
>>>
>> http://code.google.com/p/compcache/wiki/Performance
>
> That should be included in the changelog of the patches.
Which patches? The driver is already in staging and there's a pointer to
the home page in
linux/drivers/staging/ramzswap/ramzswap.txt
>> ramzswap is an optional module.
>
> I have some doubts on the wisdom of making swap algorithms modular.
> Better compile them in. Then you don't need messy notifiers either.
What's so messy about them? The whole point of having the notifiers is
to avoid CONFIG_RAMZSWAP in core kernel code...
Pekka
next prev parent reply other threads:[~2009-12-28 18:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-28 1:19 [PATCH 1/2] [mmotm] Add notifiers for various swap events Nitin Gupta
2009-12-28 1:20 ` [PATCH 2/2] [mmotm] ramzswap: add handlers " Nitin Gupta
2009-12-28 16:26 ` Yin Kangkai
2009-12-29 2:42 ` Nitin Gupta
2009-12-28 6:13 ` [PATCH 1/2] [mmotm] Add notifiers " Pekka Enberg
2009-12-28 10:21 ` Nitin Gupta
2009-12-28 15:02 ` Andi Kleen
2009-12-28 15:37 ` Nitin Gupta
2009-12-28 17:29 ` Andi Kleen
2009-12-28 18:43 ` Pekka Enberg [this message]
2009-12-28 19:23 ` Andi Kleen
2009-12-29 2:41 ` Nitin Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B38FC42.7000204@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.