From: Milan Broz <mbroz@redhat.com>
To: Max Vozeler <max@hinterhof.net>
Cc: linux-crypto@vger.kernel.org, linux-crypto@nl.linux.org,
Jari Ruusu <jariruusu@users.sourceforge.net>,
Alasdair G Kergon <agk@redhat.com>
Subject: Re: [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode
Date: Mon, 28 Dec 2009 20:37:43 +0100 [thread overview]
Message-ID: <4B390907.8010609@redhat.com> (raw)
In-Reply-To: <1262026755-23056-2-git-send-email-max@hinterhof.net>
On 12/28/2009 07:59 PM, Max Vozeler wrote:
> The original code used cc->cipher for two things:
> @@ -1014,6 +1014,7 @@ static int crypt_ctr(struct dm_target *ti, unsigned int argc, char **argv)
> char *ivopts;
> unsigned int key_size;
> unsigned long long tmpll;
> + char ciphermode[CRYPTO_MAX_ALG_NAME];
Today is CRYPTO_MAX_ALG_NAME 64 bytes but it can increase in future.
This should not be allocated on the stack.
But anyway, I see that the reason for this is to introduce multikey feature
(compatible with loop-AES mode). That's interesting idea.
But please can you add more explanation into documentation about this mode?
Is there any paper which analyses that mode - if so can you add link
to description?
(and yes, I know loop-AES documentation:-)
Milan
--
mbroz@redhat.com
next prev parent reply other threads:[~2009-12-28 19:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-28 18:59 [RFC PATCH] crypto: loop-AES support Max Vozeler
2009-12-28 18:59 ` [PATCH 1/4] dm-crypt: clarify cipher vs. cipher mode Max Vozeler
2009-12-28 19:37 ` Milan Broz [this message]
2009-12-29 1:46 ` Max Vozeler
2010-01-04 15:25 ` Max Vozeler
2010-01-11 21:28 ` Richard Zidlicky
2010-01-13 17:27 ` Max Vozeler
2010-01-17 22:02 ` Richard Zidlicky
2010-01-18 17:08 ` Max Vozeler
2010-01-18 19:51 ` Richard Zidlicky
2009-12-29 9:21 ` Richard Zidlicky
2009-12-29 11:38 ` Milan Broz
2009-12-29 17:37 ` Richard Zidlicky
2009-12-28 18:59 ` [PATCH 2/4] dm-crypt: multi tfm mode Max Vozeler
2009-12-28 18:59 ` [PATCH 3/4] crypto: md5 - Add export support Max Vozeler
2010-01-13 9:52 ` Herbert Xu
2010-01-13 17:37 ` Max Vozeler
2010-01-17 10:55 ` Herbert Xu
2009-12-28 18:59 ` [PATCH 4/4] crypto: lmk2/lmk3 cipher block modes Max Vozeler
2009-12-29 1:18 ` Richard Zidlicky
2009-12-29 1:56 ` Max Vozeler
2010-01-17 11:03 ` Herbert Xu
2010-01-18 16:52 ` Max Vozeler
2010-01-19 8:00 ` Herbert Xu
2010-02-01 10:32 ` Max Vozeler
2010-02-01 10:44 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B390907.8010609@redhat.com \
--to=mbroz@redhat.com \
--cc=agk@redhat.com \
--cc=jariruusu@users.sourceforge.net \
--cc=linux-crypto@nl.linux.org \
--cc=linux-crypto@vger.kernel.org \
--cc=max@hinterhof.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.