From: David Reiss <dreiss@facebook.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: git fast-import not verifying commit author lines?
Date: Tue, 29 Dec 2009 22:04:22 -0800 [thread overview]
Message-ID: <4B3AED66.3030803@facebook.com> (raw)
In-Reply-To: <20091222150649.GI10687@spearce.org>
>> author <somename> 1261454209 +0000
>> committer <somename> 1261454209 +0000
> a foreign system where the data might not reasonably exist.
But shouldn't there still be an extra space? One to separate "author"
from the empty name, and one to separate the empty name from the email?
If not, then I think this change should be made. (I couldn't find any
authoritative documentation on what constitutes a valid commit object.)
(Sorry, this has been sitting in my outbox for a week.)
--David
diff --git i/Documentation/git-fast-import.txt w/Documentation/git-fast-import.txt
index 288032c..6917739 100644
--- i/Documentation/git-fast-import.txt
+++ w/Documentation/git-fast-import.txt
@@ -312,6 +312,6 @@ change to the project.
'commit' SP <ref> LF
mark?
- ('author' SP <name> SP LT <email> GT SP <when> LF)?
- 'committer' SP <name> SP LT <email> GT SP <when> LF
+ ('author' (SP <name>)? SP LT <email> GT SP <when> LF)?
+ 'committer' (SP <name>)? SP LT <email> GT SP <when> LF
data
('from' SP <committish> LF)?
next prev parent reply other threads:[~2009-12-30 6:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 4:22 git fast-import not verifying commit author lines? David Reiss
2009-12-22 15:06 ` Shawn O. Pearce
2009-12-30 6:04 ` David Reiss [this message]
2009-12-30 15:03 ` [PATCH] fast-import: Document author/committer/tagger name is optional Shawn O. Pearce
2009-12-31 23:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B3AED66.3030803@facebook.com \
--to=dreiss@facebook.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.