From: Bill Davidsen <davidsen@tmr.com>
To: hooanon05@yahoo.co.jp
Cc: viro@ZenIV.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: Q. d_alloc() in pipe(2)
Date: Wed, 30 Dec 2009 22:04:18 -0500 [thread overview]
Message-ID: <4B3C14B2.8020902@tmr.com> (raw)
In-Reply-To: <20021.1262066120@jrobl>
hooanon05@yahoo.co.jp wrote:
> In pipe(2), create_write_pipe() creates a dentry by
> struct qstr name = { .name = "" };
> d_alloc(root, &name);
>
> But d_alloc() refers name->len which is uninitialized.
> Isn't it better to replace d_alloc() by d_alloc_name(root, "")?
>
If readability counts, I would say so. Functionally I don't know, I can't see
any problems other than it's unobvious.
--
Bill Davidsen <davidsen@tmr.com>
"We have more to fear from the bungling of the incompetent than from
the machinations of the wicked." - from Slashdot
prev parent reply other threads:[~2009-12-31 3:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-29 5:55 Q. d_alloc() in pipe(2) hooanon05
2009-12-29 15:02 ` Américo Wang
2009-12-30 3:41 ` hooanon05
2009-12-31 3:04 ` Bill Davidsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B3C14B2.8020902@tmr.com \
--to=davidsen@tmr.com \
--cc=hooanon05@yahoo.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.