Re: [PATCH] [IOEMU] Fix wrong INTx for pass-through device

["Zhai, Edwin" <edwin.zhai@intel.com>]

Regarding this patch, I think we need move the pci_read_intx up, or I 
would get compilation error with the reference in pt_irqpin_reg_init.

I have tested this path, both linux and windows can work, so Let's use 
physical PIN policy. Could you pls. send a new patch to Ian Jakson in a 
new thread, so that he can check in it after holiday without tracking 
this long discussion:)

BTW, could you pls. tell me how to assign the multiple function device 
to guest as it is? Setting the same virtual PCI slot?
Thanks,


Simon Horman wrote:
> Yes, the ability to make assignments like that is the crux
> of the multi-function work that I did earlier in the year.
> And the idea of not always using INTA was to avoid the
> performance penalty of reusing the virtual GSI.
>
>   
>> If we can't do this now, I think option A is also good. Is any
>> specific reason that we change to C? Does some specific multiple
>> function driver assumes specific pin other than INTA?
>>     
>
> ... so A isn't such a good option (it was before and thats what was used).
> I think that I chose C when I added multi-function because it
> avoided introducing any incompatibility for single-function pass-through.
> But at this point I think C just introduces complexity, so I now prefer B.
>
>   
>> BTW, pls. send your patch in attachment as I couldn't get it from
>> your mail:(
>>     
>
> Sure.
>
>   

-- 
best rgds,
edwin