From: Jiri Slaby <jirislaby@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: tty: &&/|| confusion in mxser_get_ISA_conf()?
Date: Thu, 31 Dec 2009 13:34:27 +0100 [thread overview]
Message-ID: <4B3C9A53.607@gmail.com> (raw)
In-Reply-To: <4B3C931A.70104@gmail.com>
On 12/31/2009 01:03 PM, Roel Kluin wrote:
> vi drivers/char/mxser.c +2460 and note:
>
> if ((irq != regs[9]) || (irq != regs[10]))
>
> Should this be an && ?
I would say not. It's a check whether irq is the same for all chips. It
jumps to a true branch iff at least one irq of the 8 is different (there
are 4 in each register). Does it make sense?
--
js
prev parent reply other threads:[~2009-12-31 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-31 12:03 tty: &&/|| confusion in mxser_get_ISA_conf()? Roel Kluin
2009-12-31 12:34 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B3C9A53.607@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.