From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NR3Yr-0001xJ-S2 for mharc-grub-devel@gnu.org; Sat, 02 Jan 2010 07:58:29 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NR3Yp-0001xE-V5 for grub-devel@gnu.org; Sat, 02 Jan 2010 07:58:27 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NR3Yk-0001we-Rs for grub-devel@gnu.org; Sat, 02 Jan 2010 07:58:26 -0500 Received: from [199.232.76.173] (port=60072 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NR3Yk-0001wb-LV for grub-devel@gnu.org; Sat, 02 Jan 2010 07:58:22 -0500 Received: from iona.labri.fr ([147.210.8.143]:52717) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NR3Yj-0005kW-U9 for grub-devel@gnu.org; Sat, 02 Jan 2010 07:58:22 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by iona.labri.fr (Postfix) with ESMTP id 71A1836B6D for ; Sat, 2 Jan 2010 13:58:20 +0100 (CET) X-Virus-Scanned: amavisd-new at labri.fr Received: from iona.labri.fr ([127.0.0.1]) by localhost (iona.labri.fr [127.0.0.1]) (amavisd-new, port 10027) with LMTP id ziyh1KusZ2Du for ; Sat, 2 Jan 2010 13:58:20 +0100 (CET) Received: from [192.168.1.50] (c2433-1-88-160-112-182.fbx.proxad.net [88.160.112.182]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by iona.labri.fr (Postfix) with ESMTP id 444B936B67 for ; Sat, 2 Jan 2010 13:58:20 +0100 (CET) Message-ID: <4B3F42EC.1010100@labri.fr> Date: Sat, 02 Jan 2010 13:58:20 +0100 From: =?ISO-8859-1?Q?Gr=E9goire_Sutre?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090707) MIME-Version: 1.0 To: The development of GNU GRUB Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Disable -Werror when error attribute generates warnings X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jan 2010 12:58:28 -0000 Hi, With an older version of gcc that does not understand the error=20 attribute, gcc generates warnings when compiling files that include=20 include/grub/list.h. Since TARGET_CFLAGS contains -Werror by default,=20 the build of modules fails. The following patch checks whether the C compiler supports the error=20 attribute without warning, and disables -Werror if that is not the case=20 (as otherwise the build will fail). http://pkgsrc-wip.cvs.sourceforge.net/viewvc/*checkout*/pkgsrc-wip/wip/gr= ub2-current/patches/patch-gcc-warning-on-error-attribute This is merely a suggestion. I'm no autoconf expert, and I'm not even=20 sure that this kind of check is a good idea, as configure has the option=20 --disable-werror that can be used anyway. Gr=E9goire p.s. I did not see this problem when I tested the patch discussed in the=20 thread [1] as I focused on building utilities at that time, sorry. [1] http://lists.gnu.org/archive/html/grub-devel/2009-12/msg00324.html