From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NR8Lk-0003pe-7c for mharc-grub-devel@gnu.org; Sat, 02 Jan 2010 13:05:16 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NR8Lh-0003nJ-Sr for grub-devel@gnu.org; Sat, 02 Jan 2010 13:05:13 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NR8Ld-0003m3-8D for grub-devel@gnu.org; Sat, 02 Jan 2010 13:05:13 -0500 Received: from [199.232.76.173] (port=49351 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NR8Ld-0003m0-5F for grub-devel@gnu.org; Sat, 02 Jan 2010 13:05:09 -0500 Received: from iona.labri.fr ([147.210.8.143]:34030) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NR8Ld-0004sp-A8 for grub-devel@gnu.org; Sat, 02 Jan 2010 13:05:09 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by iona.labri.fr (Postfix) with ESMTP id 6DFF836B73 for ; Sat, 2 Jan 2010 19:05:07 +0100 (CET) X-Virus-Scanned: amavisd-new at labri.fr Received: from iona.labri.fr ([127.0.0.1]) by localhost (iona.labri.fr [127.0.0.1]) (amavisd-new, port 10027) with LMTP id oh-pQcww7y74 for ; Sat, 2 Jan 2010 19:05:07 +0100 (CET) Received: from [192.168.1.50] (c2433-1-88-160-112-182.fbx.proxad.net [88.160.112.182]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by iona.labri.fr (Postfix) with ESMTP id 3F2B136B6F for ; Sat, 2 Jan 2010 19:05:07 +0100 (CET) Message-ID: <4B3F8AD4.7010005@labri.fr> Date: Sat, 02 Jan 2010 19:05:08 +0100 From: =?ISO-8859-1?Q?Gr=E9goire_Sutre?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090707) MIME-Version: 1.0 To: The development of GNU GRUB References: <4B3F42EC.1010100@labri.fr> <20100102153738.GX5847@riva.ucam.org> In-Reply-To: <20100102153738.GX5847@riva.ucam.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Disable -Werror when error attribute generates warnings X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jan 2010 18:05:14 -0000 Colin Watson wrote: > Instead of this, why not only use the attribute if it's available? I > couldn't find an entry about it in GCC's human-readable change > summaries, but support was committed on 2007-09-23 so I think it's > available from GCC 4.3. >=20 > I use this GNUC_PREREQ approach in other projects and rather like it. I= t > could be extended to cover our other uses of attributes quite easily. Nice trick :-) I confirm that this patch works with gcc 4.1.3 on NetBSD. And it's=20 definitely better than completely disabling -Werror... Thanks, Gr=E9goire