From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NRGcL-00074q-8N for mharc-grub-devel@gnu.org; Sat, 02 Jan 2010 21:54:57 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NRGcI-00074B-VI for grub-devel@gnu.org; Sat, 02 Jan 2010 21:54:54 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NRGcE-00073V-1f for grub-devel@gnu.org; Sat, 02 Jan 2010 21:54:54 -0500 Received: from [199.232.76.173] (port=50539 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRGcD-00073S-Sj for grub-devel@gnu.org; Sat, 02 Jan 2010 21:54:49 -0500 Received: from iona.labri.fr ([147.210.8.143]:56982) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NRGcD-0004fs-L4 for grub-devel@gnu.org; Sat, 02 Jan 2010 21:54:49 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by iona.labri.fr (Postfix) with ESMTP id 8397736B79 for ; Sun, 3 Jan 2010 03:54:46 +0100 (CET) X-Virus-Scanned: amavisd-new at labri.fr Received: from iona.labri.fr ([127.0.0.1]) by localhost (iona.labri.fr [127.0.0.1]) (amavisd-new, port 10027) with LMTP id xyU1lx+9pviU for ; Sun, 3 Jan 2010 03:54:46 +0100 (CET) Received: from [192.168.1.50] (c2433-1-88-160-112-182.fbx.proxad.net [88.160.112.182]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by iona.labri.fr (Postfix) with ESMTP id 5713B36B78 for ; Sun, 3 Jan 2010 03:54:46 +0100 (CET) Message-ID: <4B4006F9.30402@labri.fr> Date: Sun, 03 Jan 2010 03:54:49 +0100 From: =?ISO-8859-1?Q?Gr=E9goire_Sutre?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090707) MIME-Version: 1.0 To: The development of GNU GRUB Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Check for device type (block/character) in grub-setup? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jan 2010 02:54:55 -0000 Hi, I'm wondering why there is no check for device type (block/character) in=20 grub-setup.c whereas the function probe() in grub-probe.c exits with=20 error if the device is not of the expected type. Shouldn't there be a=20 similar check in grub-setup? Currently, on NetBSD (with in-progress patches), grub-setup fails with=20 an `out of disk error' on a block device as the detected disk size is 0,=20 whereas grub-probe exits gracefully with an error message telling that=20 the input device is not a character device. I guess that a similar=20 behavior could be observed on FreeBSD, but I can't actually test this. Thanks, Gr=E9goire