Re: [PATCH] mm : add check for the return value

[shijie8 <shijie8@gmail.com>]

> I think it's not desirable to add new branch in hot-path even though
> we could avoid that.
>
> How about this?
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 4e4b5b3..87976ad 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1244,6 +1244,9 @@ again:
>          return page;
>
>   failed:
>    
you miss anther place where also  uses "goto failed".
> +       spin_lock(&zone->lock);
> +       __mod_zone_page_state(zone, NR_FREE_PAGES, 1<<  order);
> +       spin_unlock(&zone->lock);
>          local_irq_restore(flags);
>          put_cpu();
>          return NULL;
>
>    
I also thought  over your method before I sent the patch,  but there 
already exits a
"if (!page)" , I not sure whether my patch adds too much delay in hot-path.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>