From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] phy: SMSC device Energy Detect power-down mode
Date: Mon, 04 Jan 2010 11:01:09 +0100 [thread overview]
Message-ID: <4B41BC65.6060301@st.com> (raw)
In-Reply-To: <20091225.183829.246551084.davem@davemloft.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi David,
David Miller wrote:
> From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
> Date: Wed, 16 Dec 2009 08:28:18 +0100
>
>> SMSC Ethernet Transceivers (LAN88710, LAN8710, LAN8720, LAN8187,
>> LAN8700, LAN83C185) provide a mechanism to conserve power when
>> the device is not connected to an active link partner
>> (Energy Detect Mode).
>> So this patch enables the Energy Detect power-down mode
>> for these Transceivers.
>>
>> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>
> Both phy_read() and phy_write() can return errors, you must check
> for them. The rest of this driver does this properly.
I'm resending the patch with this fixed.
Thanks,
Peppe
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAktBvGUACgkQ2Xo3j31MSSLA/gCfRSXQ7i/GEiZjPAHV4ZUxoxM5
YTUAoIPTXQ82zgsjj3q1gSdn1vY0G/dr
=fJnv
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2010-01-04 10:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 7:28 [PATCH] phy: SMSC device Energy Detect power-down mode Giuseppe CAVALLARO
2009-12-26 2:38 ` David Miller
2010-01-04 10:01 ` Giuseppe CAVALLARO [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B41BC65.6060301@st.com \
--to=peppe.cavallaro@st.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.