Re: [PATCH] drivers/infiniband/hw/cxgb3/iwch_cm.c: use %pM to show MAC address

[Steve Wise <swise@opengridcomputing.com>]

Acked-by: Steve Wise <swise@opengridcomputing.com>


H Hartley Sweeten wrote:
> Use the %pM kernel extension to display the MAC address.
>
> The only difference in the output is that the MAC address is
> shown in the usual colon-separated hex notation.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Steve Wise <swise@chelsio.com>
>
> ---
>
> diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
> index 66b4135..d94388b 100644
> --- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
> +++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
> @@ -1371,15 +1371,8 @@ static int pass_accept_req(struct t3cdev *tdev, struct sk_buff *skb, void *ctx)
>  	tim.mac_addr = req->dst_mac;
>  	tim.vlan_tag = ntohs(req->vlan_tag);
>  	if (tdev->ctl(tdev, GET_IFF_FROM_MAC, &tim) < 0 || !tim.dev) {
> -		printk(KERN_ERR
> -			"%s bad dst mac %02x %02x %02x %02x %02x %02x\n",
> -			__func__,
> -			req->dst_mac[0],
> -			req->dst_mac[1],
> -			req->dst_mac[2],
> -			req->dst_mac[3],
> -			req->dst_mac[4],
> -			req->dst_mac[5]);
> +		printk(KERN_ERR "%s bad dst mac %pM\n",
> +			__func__, req->dst_mac);
>  		goto reject;
>  	}
>   
>