All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: linux-mmc@vger.kernel.org
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
Subject: MMC: Atmel choice under Kconfig
Date: Mon, 04 Jan 2010 16:21:02 +0000	[thread overview]
Message-ID: <4B42156E.3050103@cam.ac.uk> (raw)

Just a nitpicking comment. Currently even if one doesn't actually
have an atmel chip, the menu will include an entry Atmel SD/MMC Driver
due to the following bit of drivers/mmc/host/kconfig

choice
	prompt "Atmel SD/MMC Driver"
	default MMC_ATMELMCI if AVR32
	help
	  Choose which driver to use for the Atmel MCI Silicon

config MMC_AT91
	tristate "AT91 SD/MMC Card Interface support"
	depends on ARCH_AT91
	help
	  This selects the AT91 MCI controller.

	  If unsure, say N.

config MMC_ATMELMCI
	tristate "Atmel Multimedia Card Interface support"
	depends on AVR32 || ARCH_AT91
	help
	  This selects the Atmel Multimedia Card Interface driver. If
	  you have an AT32 (AVR32) or AT91 platform with a Multimedia
	  Card slot, say Y or M here.

	  If unsure, say N.

endchoice

Does anyone object to making adding a dependency on AVR32 || ARCH_AT91
to the 'choice' entry so as to clean up what everyone else sees?

Sorry for the noise if there is already a patch for this queued up
somewhere.

Thanks,

Jonathan Cameron

             reply	other threads:[~2010-01-04 16:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-04 16:21 Jonathan Cameron [this message]
2010-01-04 16:25 ` MMC: Atmel choice under Kconfig Nicolas Ferre
2010-01-04 16:38   ` [PATCH] MMC: Atmel host kconfig cleanup for everyone else Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B42156E.3050103@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=linux-mmc@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.