From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NSFVN-0002ou-BW
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:55:49 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NSFVG-0002lM-Gj
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:55:42 -0500
Received: from [199.232.76.173] (port=43056 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NSFVE-0002kE-HG
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:55:41 -0500
Received: from mx20.gnu.org ([199.232.41.8]:36473)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <rth@twiddle.net>) id 1NSFV6-0005HS-Fr
	for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:55:32 -0500
Received: from are.twiddle.net ([75.149.56.221])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rth@twiddle.net>) id 1NRxLK-00087e-Se
	for qemu-devel@nongnu.org; Mon, 04 Jan 2010 19:32:15 -0500
Message-ID: <4B424B87.1080508@twiddle.net>
Date: Mon, 04 Jan 2010 12:11:51 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [patch] alpha-linux-user stat64 issue
References: <20091228235833.H44497@stanley.csl.cornell.edu>
In-Reply-To: <20091228235833.H44497@stanley.csl.cornell.edu>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vince Weaver <vince@csl.cornell.edu>
Cc: qemu-devel@nongnu.org

On 12/28/2009 09:01 PM, Vince Weaver wrote:
> Hello
>
> The stat64/fstat64 syscalls are broken for alpha linux-user.
>
> This is because Alpha, even though it is native 64-bits, has a stat64
> syscall that is different than regular stat.  This means that the
> "TARGET_LONG_BITS==64" check in syscall.c isn't enough.  Below is
> a patch that fixes things for me, although it might not be the cleanest
> fix.
>
> This issue keeps sixtrack and fma3d spec2k benchmarks from running.
>
> Vince
>
> Signed-off-by: Vince Weaver<vince@csl.cornell.edu>
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 1acf1f5..f2dd39e 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -4004,7 +4004,7 @@ static inline abi_long host_to_target_stat64(void *cpu_env,
>       } else
>   #endif
>       {
> -#if TARGET_LONG_BITS == 64
> +#if (TARGET_LONG_BITS == 64)&&  (!defined(TARGET_ALPHA))
>           struct target_stat *target_st;
>   #else
>           struct target_stat64 *target_st;
>
>

Acked-by: Richard Henderson <rth@twiddle.net>


r~