All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, agraf@suse.de
Subject: [Qemu-devel] Re: [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus
Date: Tue, 05 Jan 2010 10:27:19 +0100	[thread overview]
Message-ID: <4B4305F7.2040707@redhat.com> (raw)
In-Reply-To: <1262626457-26671-3-git-send-email-amit.shah@redhat.com>

   Hi,

> +/* Guest wants to notify us of some event */
> +static void handle_control_message(VirtIOSerial *vser, void *buf)
> +{

> +    cpkt->event = le16_to_cpu(cpkt->event);
> +    cpkt->value = le16_to_cpu(cpkt->value);

Does this modify guest memory?

> +        DEFINE_PROP_UINT8("is_console", VirtConsole, port.is_console, 1),

virtser_bus_dev_print() prints this.  Properties are printed by "info 
qtree" anyway, so you can drop that from virtser_bus_dev_print ...

cheers,
   Gerd

  parent reply	other threads:[~2010-01-05 19:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-04 17:34 [Qemu-devel] [PATCH 0/8] virtio-console: Move to qdev, multiple devices, generic ports Amit Shah
2010-01-04 17:34 ` [Qemu-devel] [PATCH 1/8] virtio: Remove duplicate macro definition for max. virtqueues, bump up the max Amit Shah
2010-01-04 17:34   ` [Qemu-devel] [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus Amit Shah
2010-01-04 17:34     ` [Qemu-devel] [PATCH 3/8] virtio-serial-bus: Maintain guest and host port open/close state Amit Shah
2010-01-04 17:34       ` [Qemu-devel] [PATCH 4/8] virtio-serial-bus: Add a port 'name' property for port discovery in guests Amit Shah
2010-01-04 17:34         ` [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests Amit Shah
2010-01-04 17:34           ` [Qemu-devel] [PATCH 6/8] virtio-serial-bus: Add ability to hot-unplug ports Amit Shah
2010-01-04 17:34             ` [Qemu-devel] [PATCH 7/8] virtio-serial: Add 'virtserialport' device for generic serial port support Amit Shah
2010-01-04 17:34               ` [Qemu-devel] [PATCH 8/8] Move virtio-serial and virtio-serial-bus to Makefile.hw Amit Shah
2010-01-05  9:27     ` Gerd Hoffmann [this message]
2010-01-05 14:34       ` [Qemu-devel] Re: [PATCH 2/8] virtio-console: qdev conversion, new virtio-serial-bus Amit Shah
2010-01-05 16:42     ` [Qemu-devel] " Anthony Liguori
2010-01-05 17:04       ` Gerd Hoffmann
2010-01-05 17:08         ` Anthony Liguori
2010-01-05 17:16       ` Amit Shah
2010-01-05 17:25         ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B4305F7.2040707@redhat.com \
    --to=kraxel@redhat.com \
    --cc=agraf@suse.de \
    --cc=amit.shah@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.