From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NSQI4-0002SI-4V
	for qemu-devel@nongnu.org; Wed, 06 Jan 2010 02:26:48 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NSQI3-0002S6-5G
	for qemu-devel@nongnu.org; Wed, 06 Jan 2010 02:26:47 -0500
Received: from [199.232.76.173] (port=36936 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NSQI3-0002S3-2D
	for qemu-devel@nongnu.org; Wed, 06 Jan 2010 02:26:47 -0500
Received: from hall.aurel32.net ([88.191.82.174]:51720)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1NSQI2-0003MN-N5
	for qemu-devel@nongnu.org; Wed, 06 Jan 2010 02:26:46 -0500
Message-ID: <4B443B2D.7080506@aurel32.net>
Date: Wed, 06 Jan 2010 08:26:37 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH V11 01/27] acpi: split out pc smbus	routines
	from acpi.c into pc_smbus.c
References: <1262672870-22607-1-git-send-email-yamahata@valinux.co.jp>	<1262672870-22607-2-git-send-email-yamahata@valinux.co.jp>	<20100105221100.GO9638@hall.aurel32.net>
	<20100106012431.GD29412@valinux.co.jp>
In-Reply-To: <20100106012431.GD29412@valinux.co.jp>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com

Isaku Yamahata a écrit :
> On Tue, Jan 05, 2010 at 11:11:00PM +0100, Aurelien Jarno wrote:
>> On Tue, Jan 05, 2010 at 03:27:24PM +0900, Isaku Yamahata wrote:
>>> Split out pc smbus routines from acpi.c into pc_smbus.c and
>>> use it.
>> Given the code is not specific to PC, but is also used on MIPS, I am not
>> sure pc_smbus is the best name.
> 
> Okay. I'll drop pc_ prefix. (for both file name and function names).
> Do you also want similar to pc_apm.c in the next patch?
> 

Yes, it looks better to me.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net