From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NSUIG-0002wm-T8
	for qemu-devel@nongnu.org; Wed, 06 Jan 2010 06:43:16 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NSUIC-0002vL-0i
	for qemu-devel@nongnu.org; Wed, 06 Jan 2010 06:43:16 -0500
Received: from [199.232.76.173] (port=52475 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NSUIB-0002vI-SV
	for qemu-devel@nongnu.org; Wed, 06 Jan 2010 06:43:11 -0500
Received: from moutng.kundenserver.de ([212.227.126.186]:65148)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1NSUIA-0000ho-Bu
	for qemu-devel@nongnu.org; Wed, 06 Jan 2010 06:43:10 -0500
Message-ID: <4B447724.6070708@mail.berlios.de>
Date: Wed, 06 Jan 2010 12:42:28 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH V12 24/27] pm_smbus: remove #ifdef DEBUG.
References: <1262745591-28697-1-git-send-email-yamahata@valinux.co.jp>
	<1262745591-28697-25-git-send-email-yamahata@valinux.co.jp>
In-Reply-To: <1262745591-28697-25-git-send-email-yamahata@valinux.co.jp>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net, kraxel@redhat.com

Isaku Yamahata schrieb:
> remove #ifdef DEBUG by using macro.
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/pm_smbus.c | 21 ++++++++++++---------
> 1 files changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/hw/pm_smbus.c b/hw/pm_smbus.c
> index 6ef6b9e..9929d72 100644
> --- a/hw/pm_smbus.c
> +++ b/hw/pm_smbus.c
> @@ -37,6 +37,15 @@
> #define SMBHSTDAT1 0x06
> #define SMBBLKDAT 0x07
>
> +//#define DEBUG
> +
> +#ifdef DEBUG
> +# define SMBUS_DPRINTF(format, ...) printf(format, ## __VA_ARGS__)

Debug output should go to stderr. So this would be even better:

+# define SMBUS_DPRINTF(format, ...) fprintf(stderr, format, ## __VA_ARGS__)

Regards,

Stefan Weil