From: Arjan van de Ven <arjan@linux.intel.com>
To: Hui Zhu <teawater@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Ozan Çaglayan" <ozan@pardus.org.tr>,
"Matthew Wilcox" <willy@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix markup_oops.pl get error in x86
Date: Wed, 06 Jan 2010 05:23:47 -0800 [thread overview]
Message-ID: <4B448EE3.5060200@linux.intel.com> (raw)
In-Reply-To: <daef60381001060123vbb09aecy7943d72fcb8278a@mail.gmail.com>
On 1/6/2010 1:23, Hui Zhu wrote:
> }
> $func_offset will get a number like "0x2"
> But in follow code:
> my $decodestart = Math::BigInt->from_hex("0x$target") -
> Math::BigInt->from_hex("0x$func_offset");
> It add other ox to ox2.
> Then this value will be set to NaN.
>
> So I make a small patch to fix it.
> - if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+(0x[0-9a-f]+)\/0x[a-f0-9]/) {
> + if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/[a-f0-9]/) {
I think this makes sense, but would you not also need to add "x" to the list of allowed characters?
so [a-f0-9x]
?
next prev parent reply other threads:[~2010-01-06 13:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 9:23 [PATCH] Fix markup_oops.pl get error in x86 Hui Zhu
2010-01-06 13:23 ` Arjan van de Ven [this message]
2010-01-07 5:43 ` Hui Zhu
2010-01-07 13:03 ` Arjan van de Ven
2010-01-11 2:59 ` Hui Zhu
2010-01-12 3:02 ` Hui Zhu
2010-01-06 13:45 ` Ozan Çağlayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B448EE3.5060200@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ozan@pardus.org.tr \
--cc=sam@ravnborg.org \
--cc=teawater@gmail.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.