From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4B449EB0.5090107@grandegger.com> Date: Wed, 06 Jan 2010 15:31:12 +0100 From: Wolfgang Grandegger MIME-Version: 1.0 To: Netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 0/3] can: mscan-mpc5xxx: add support for the Freescale MPC512x References: <1262719241-2422-1-git-send-email-wg@grandegger.com> In-Reply-To: <1262719241-2422-1-git-send-email-wg@grandegger.com> Content-Type: text/plain; charset=ISO-8859-1 Cc: Socketcan-core@lists.berlios.de, Devicetree-discuss@lists.ozlabs.org, Linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Wolfgang Grandegger wrote: > This patch series adds support for the MPC512x from Freescale to > the mpc5xxx_can MSCAN driver. > > Changes since v1: > > - Various coding style issues, printk formats, variable names and > error messagaes and typos fixes or improved > > - MPC5xxx specific data are now passed to mpc5xxx_can_probe() via > "of_device_id->data". > > - The index of the MPC512x CAN controller is now derived directly > from reg property. This allows use of_iomap() as usual. > > - It has been documented that MPC512x Rev.1 CPUs are not supported. As you might have already realized, this patch set slipped out accidentally to the mailing list due to a bug in my patch-format-test-and-send-email script. Nevertheless, it's good enough for reviewing and testing. Just some debugging code needs to be removed. Wolfram, is it OK from your point of view now? I will roll out v3 after some more thorough testing tomorrow. Wolfgang. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH net-next v2 0/3] can: mscan-mpc5xxx: add support for the Freescale MPC512x Date: Wed, 06 Jan 2010 15:31:12 +0100 Message-ID: <4B449EB0.5090107@grandegger.com> References: <1262719241-2422-1-git-send-email-wg@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1262719241-2422-1-git-send-email-wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org To: Netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, Devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org Wolfgang Grandegger wrote: > This patch series adds support for the MPC512x from Freescale to > the mpc5xxx_can MSCAN driver. > > Changes since v1: > > - Various coding style issues, printk formats, variable names and > error messagaes and typos fixes or improved > > - MPC5xxx specific data are now passed to mpc5xxx_can_probe() via > "of_device_id->data". > > - The index of the MPC512x CAN controller is now derived directly > from reg property. This allows use of_iomap() as usual. > > - It has been documented that MPC512x Rev.1 CPUs are not supported. As you might have already realized, this patch set slipped out accidentally to the mailing list due to a bug in my patch-format-test-and-send-email script. Nevertheless, it's good enough for reviewing and testing. Just some debugging code needs to be removed. Wolfram, is it OK from your point of view now? I will roll out v3 after some more thorough testing tomorrow. Wolfgang.