All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH] lockfile: show absolute filename in unable_to_lock_message.
Date: Wed, 06 Jan 2010 19:50:18 +0100	[thread overview]
Message-ID: <4B44DB6A.2050804@kdbg.org> (raw)
In-Reply-To: <1262797288-23004-1-git-send-email-Matthieu.Moy@imag.fr>

Matthieu Moy schrieb:
> -		    path, strerror(err));
> +			    make_absolute_path(path), strerror(err));
>  	} else
> -		strbuf_addf(&buf, "Unable to create '%s.lock': %s", path, strerror(err));
> +		strbuf_addf(&buf, "Unable to create '%s.lock': %s",
> +			    make_absolute_path(path), strerror(err));

Since these are merely informative, wouldn't it be more suitable to use 
make_nonrelative_path()?

-- Hannes

  reply	other threads:[~2010-01-06 18:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-06 17:01 [RFC/PATCH] lockfile: show absolute filename in unable_to_lock_message Matthieu Moy
2010-01-06 18:50 ` Johannes Sixt [this message]
2010-01-07 14:54   ` [PATCH] " Matthieu Moy
2010-01-12 10:20     ` Matthieu Moy
2010-01-13  6:56     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B44DB6A.2050804@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=Matthieu.Moy@imag.fr \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.