Re: [PATCH 2.6.33] mac80211: fix skb buffering issue

[Felix Fietkau <nbd@openwrt.org>]

On 2010-01-06 10:51 PM, Johannes Berg wrote:
> On Wed, 2010-01-06 at 23:26 +0200, Thomas Backlund wrote:
> 
>> With this patch applied to 2.6.33-rc3 kernel crashes at boot...
>> 
>> I have a iwl4965 connecting to a wpa2-psk encrypted network, arch is 
>> x86_64, distro Mandriva Linux and the kernel has preempt enabled.
>> 
>> Am I only missing some patches, or did I hit a real bug ?
> 
> It'd help if you said what crashes and how since nobody else seems to be
> having that particular problem with this patch.
I have an idea.
The patch adds the following chunk of code:
> +	if (!sta && ra && !is_multicast_ether_addr(ra)) {
> +		sta = sta_info_get(sdata, ra);
> +		if (sta)
> +			sta_flags = get_sta_flags(sta);
In wireless-testing, sta_info_get takes sdata as first argument, in
2.6.33-rc3 it expects a pointer to local. This should have emitted a
compiler warning... I saw the same thing when applying the patch to an
older compat-wireless snapshot.

- Felix