Re: VNC framebuffer block artefacts on qemu-kvm-0.12.1.1

[Mark Cave-Ayland <mark.cave-ayland@siriusit.co.uk>]

Anthony Liguori wrote:

> What about just adding back this bit:
> 
> @@ -165,6 +165,8 @@ static void CONCAT(send_hextile_tile_, 
> NAME)(VncState *vs,
>          irow += ds_get_linesize(vs->ds) / sizeof(pixel_t);
>      }
> 
> +    /* A SubrectsColoured subtile invalidates the foreground color */
> +    *has_fg = 0;
>      if (n_data>  (w * h * sizeof(pixel_t))) {
>          n_colors = 4;
>          flags = 0x01;
> 
> I think I can rationalize why that would be needed.

Hi Anthony,

I've done a rebuild with just the above part of the patch applied, and I 
can confirm that indeed it resolves the problem on my WinXP guest here.


Many thanks,

Mark.

-- 
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063

Sirius Labs: http://www.siriusit.co.uk/labs