From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Cave-Ayland <mark.cave-ayland@siriusit.co.uk>
Subject: Re: VNC framebuffer block artefacts on qemu-kvm-0.12.1.1
Date: Wed, 06 Jan 2010 22:21:30 +0000
Message-ID: <4B450CEA.9030306@siriusit.co.uk>
References: <4B4364AE.8080509@siriusit.co.uk> <20100106135118.GA28640@amt.cnet> <4B44DF46.3030503@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Yaniv Kaul <ykaul@redhat.com>, kvm@vger.kernel.org
To: Anthony Liguori <aliguori@linux.vnet.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from ra.siriusit.co.uk ([217.207.197.130]:47849 "EHLO
	ra.siriusit.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755100Ab0AFWWB (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 6 Jan 2010 17:22:01 -0500
In-Reply-To: <4B44DF46.3030503@linux.vnet.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Anthony Liguori wrote:

> What about just adding back this bit:
> 
> @@ -165,6 +165,8 @@ static void CONCAT(send_hextile_tile_, 
> NAME)(VncState *vs,
>          irow += ds_get_linesize(vs->ds) / sizeof(pixel_t);
>      }
> 
> +    /* A SubrectsColoured subtile invalidates the foreground color */
> +    *has_fg = 0;
>      if (n_data>  (w * h * sizeof(pixel_t))) {
>          n_colors = 4;
>          flags = 0x01;
> 
> I think I can rationalize why that would be needed.

Hi Anthony,

I've done a rebuild with just the above part of the patch applied, and I 
can confirm that indeed it resolves the problem on my WinXP guest here.


Many thanks,

Mark.

-- 
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063

Sirius Labs: http://www.siriusit.co.uk/labs