From: Anthony Liguori <anthony@codemonkey.ws>
To: Milan Plzik <milan.plzik@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Qemu's internal TFTP server breaks lock-step-iness of TFTP
Date: Wed, 06 Jan 2010 16:43:57 -0600 [thread overview]
Message-ID: <4B45122D.1020403@codemonkey.ws> (raw)
In-Reply-To: <1262815902.18404.341.camel@localhost>
On 01/06/2010 04:11 PM, Milan Plzik wrote:
> Hello,
>
> according to RFC 1350 and RFC 2347, TFTP server should answer RRQ by
> either OACK or DATA packet. Qemu's internal TFTP server answers RRQ with
> additional options by sending both OACK and DATA packet, thus breaking
> the "lock-step" feature of the protocol, and also confuses client.
>
> Proposed solution would be to, in case of OACK packet, wait for ACK
> from client and just then start sending data. Attached patch implements
> this.
>
> I would like to thank to mbc and th1 (who is the rightful author of
> the patch) from #gpxe for their time, effort and patience with me :)
>
Thanks for the patch, I assume this fixes -boot n when using -bootp and
-tftp. Can you add an appropriate Signed-off-by and resubmit?
Regards,
Anthony Liguori
> Milan Plzik
>
next prev parent reply other threads:[~2010-01-06 22:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 22:11 [Qemu-devel] Qemu's internal TFTP server breaks lock-step-iness of TFTP Milan Plzik
2010-01-06 22:43 ` Anthony Liguori [this message]
2010-01-07 12:51 ` Milan Plzik
2010-01-07 15:42 ` H. Peter Anvin
-- strict thread matches above, loose matches on Subject: below --
2010-01-07 12:39 Milan Plzik
2010-01-13 23:26 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B45122D.1020403@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=milan.plzik@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.