From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: Andy Gospodarek <andy@greyhouse.net>,
Tom Herbert <therbert@google.com>,
David Miller <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] fix bonding: allow arp_ip_targets on separate vlans to use arp validation
Date: Thu, 07 Jan 2010 09:37:58 +0100 [thread overview]
Message-ID: <4B459D66.5060307@gmail.com> (raw)
In-Reply-To: <13683.1262822029@death.nxdomain.ibm.com>
Le 07/01/2010 00:53, Jay Vosburgh a écrit :
> Andy Gospodarek <andy@greyhouse.net> wrote:
>
>> This patch fixes up a problem with found with commit
>> 1f3c8804acba841b5573b953f5560d2683d2db0d. The original change
>> overloaded null_or_orig, but doing that prevented any packet handlers
>> that were not tied to a specific device (i.e. ptype->dev == NULL) from
>> ever receiving any frames.
>>
>> The null_or_orig variable cannot be overloaded, and must be kept as NULL
>> to prevent the frame from being ignored by packet handlers designed to
>> accept frames on any interface.
>>
>> Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
>
> Tested, and it appears to work fine. Tcpdump also appears to
> behave rationally.
>
> -J
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Tested as well on my machine, I confirm this fixes the problem I had.
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Thanks guys !
next prev parent reply other threads:[~2010-01-07 8:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 23:28 [PATCH v4 1/1] rps: core implementation Tom Herbert
2009-11-20 23:39 ` David Miller
2009-11-20 23:50 ` Tom Herbert
2009-11-21 0:05 ` David Miller
2009-11-21 0:12 ` Tom Herbert
2009-11-21 0:40 ` Jarek Poplawski
2009-11-20 23:40 ` Stephen Hemminger
2009-11-20 23:53 ` Tom Herbert
2009-11-20 23:56 ` David Miller
2009-12-17 21:04 ` Tom Herbert
2010-01-06 1:32 ` Tom Herbert
2010-01-06 5:54 ` Eric Dumazet
2010-01-06 7:56 ` Tom Herbert
2010-01-06 18:38 ` Eric Dumazet
2010-01-06 21:10 ` [BUG net-next-2.6] Had to revert bonding: allow arp_ip_targets on separate vlans to use arp validation Eric Dumazet
2010-01-06 21:28 ` Jay Vosburgh
2010-01-06 21:34 ` Eric Dumazet
2010-01-06 21:38 ` David Miller
2010-01-06 21:45 ` Andy Gospodarek
2010-01-06 22:56 ` [PATCH net-next-2.6] fix " Andy Gospodarek
2010-01-06 23:53 ` Jay Vosburgh
2010-01-07 8:37 ` Eric Dumazet [this message]
2010-01-07 8:41 ` David Miller
2010-01-06 22:54 ` [PATCH v4 1/1] rps: core implementation Tom Herbert
2010-01-07 9:15 ` Eric Dumazet
2010-01-07 17:42 ` rps: some comments Eric Dumazet
2010-01-08 0:07 ` Tom Herbert
2010-01-08 6:27 ` Eric Dumazet
2010-01-11 6:25 ` [PATCH v4 1/1] rps: core implementation Tom Herbert
2010-01-11 9:00 ` Eric Dumazet
2010-01-14 4:40 ` David Miller
2009-11-20 23:42 ` Stephen Hemminger
2009-11-21 0:04 ` Tom Herbert
2009-11-21 8:07 ` Eric Dumazet
2009-11-21 9:03 ` Tom Herbert
2009-11-21 9:31 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B459D66.5060307@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.