From: Jean-Hugues Deschenes <jean-hugues.deschenes@octasic.com>
To: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 03/13] stmmac: add the new Header file for stmmac platform data
Date: Thu, 07 Jan 2010 08:46:43 -0500 [thread overview]
Message-ID: <4B45E5C3.6060205@octasic.com> (raw)
In-Reply-To: <4B45E1D7.80407@st.com>
Giuseppe CAVALLARO wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Jean-Hugues,
>
> Jean-Hugues Deschenes wrote:
>
>> Coming to think of it, it might be preferable to locate this file in
>> drivers/net/stmmac/stmmac_plat.h and have the platform-specific code do
>> inclusions like: #include "../../../drivers/net/stmmac/stmmac_plat.h"
>>
>
> Indeed, I don't like the include/linux/stmmac.h file but it's not only,
> see the dm9000.h file.
>
> Moreover, moving this header file within drivers/net/stmmac directory,
> each board setup file (arch/sh/boards/mach-<name>/setup.c should have
> #include "../../../../drivers/net/stmmac/stmmac_plat.h". Is it a good
> solution?
I took a look at the the arch subdirectory before suggesting this:
grep -RI "^\#include.*\/drivers" *
m32r/platforms/usrv/io.c:#include "../../../../drivers/pcmcia/m32r_cfc.h"
s390/mm/cmm.c:#include "../../../drivers/s390/net/smsgiucv.h"
x86/kernel/asm-offsets_32.c:#include "../../../drivers/lguest/lg.h"
... so we wouldn't be the only ones... but then again, as with your
Davicom dm9000.h example, we wouldn't be the only ones to locate it in
include/linux either... so...?
jh
next prev parent reply other threads:[~2010-01-07 13:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 9:07 [PATCH 01/13] stmmac: use MII_BUS_ID_SIZE instead of BUS_ID_SIZE Giuseppe CAVALLARO
2010-01-07 9:07 ` [PATCH 02/13] stmmac: convert unicast addr list to list_head Giuseppe CAVALLARO
2010-01-07 9:07 ` [PATCH 03/13] stmmac: add the new Header file for stmmac platform data Giuseppe CAVALLARO
2010-01-07 9:07 ` [PATCH 04/13] stmmac: rewiew " Giuseppe CAVALLARO
2010-01-07 9:07 ` [PATCH 05/13] stmmac: perform hw bus configuration Giuseppe CAVALLARO
2010-01-07 9:07 ` [PATCH 06/13] stmmac: do not call fix_mac_speed if NULL Giuseppe CAVALLARO
2010-01-07 9:07 ` [PATCH 07/13] stmmac: reorganise class operations Giuseppe CAVALLARO
2010-01-07 9:07 ` [PATCH 08/13] stmmac: move the dma out from the main Giuseppe CAVALLARO
2010-01-07 9:07 ` [PATCH 09/13] stmmac: rename mac100 as dwmac100 and fix spare coding style Giuseppe CAVALLARO
2010-01-07 9:07 ` [PATCH 10/13] stmmac: rename the gmac as dwmac1000 and split core and dma parts Giuseppe CAVALLARO
2010-01-07 9:07 ` [PATCH 11/13] stmmac: include netdevice.h into the common.h header Giuseppe CAVALLARO
2010-01-07 9:07 ` [PATCH 12/13] stmmac: improve Kconfig help Giuseppe CAVALLARO
2010-01-07 9:07 ` [PATCH 13/13] stmmac: update the driver's module version Giuseppe CAVALLARO
2010-01-07 13:13 ` [PATCH 03/13] stmmac: add the new Header file for stmmac platform data Jean-Hugues Deschenes
2010-01-07 13:29 ` Giuseppe CAVALLARO
2010-01-07 13:46 ` Jean-Hugues Deschenes [this message]
2010-01-07 14:01 ` Giuseppe CAVALLARO
2010-01-07 14:14 ` Jean-Hugues Deschenes
2010-01-07 14:20 ` Giuseppe CAVALLARO
2010-01-07 14:34 ` Jean-Hugues Deschenes
2010-01-07 15:03 ` Giuseppe CAVALLARO
2010-01-07 15:06 ` Jean-Hugues Deschenes
2010-01-08 1:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B45E5C3.6060205@octasic.com \
--to=jean-hugues.deschenes@octasic.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.