From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/9] Added support for SPEAr SoCs
Date: Thu, 07 Jan 2010 10:42:00 -0600 [thread overview]
Message-ID: <4B460ED8.5030101@windriver.com> (raw)
In-Reply-To: <1262865390-2016-1-git-send-email-vipin.kumar@st.com>
Vipin KUMAR wrote:
> This patch set is a reworked patch which incorporates all review feedbacks from
> earlier earlier mails
>
> This patch set contains the support for 4 SoCs
> SPEAr600
> SPEAr300
> SPEAr310
> SPEAr320
>
> SPEAr is an ARM based SoC which supports rich set of peripherals like Ethernet,
> USB Host, USB Device etc to support various general applications
>
> For further info on SPEAr SoC, please see README.spear also contained in the
> patch set.
>
> Vipin (9):
> Added README.spear
> SPEAr600 SoC support added
> SPEAr300 SoC support added
> SPEAr310 SoC support added
> SPEAr320 SoC support added
> i2c driver support for SPEAr SoCs
> smi driver support for SPEAr SoCs
> nand(fsmc) driver support for SPEAr SoCs
> usbd driver support for SPEAr SoCs
This review is mechanical.
Whitespace/formatting checking with checkpatch.pl is in general ok.
Some warnings about braces, fix if you think approprate
On patch 9,
ERROR: "foo * bar" should be "foo *bar"
#283: FILE: drivers/usb/gadget/spr_udc.c:229:
+static void usbputpcktofifo(int epNum, u8 * bufp, u32 len)
These should fixed
The readme has trailing whitespace issues that were caught in the 'git am '
Please fix.
On patch 9, usb.
There are some merge warnings.
Applying: usbd driver support for SPEAr SoCs
error: patch failed: drivers/serial/usbtty.h:31
error: drivers/serial/usbtty.h: patch does not apply
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merged drivers/serial/usbtty.h
There are some recent updates for usb.
Please rebase you source.
On MAKEALL arm
Spear boards fail to build
Errors similar to this
Assembler messages:
Fatal error: can't create build/board/spear/spear300/../common/spr_misc.o: No
such file or directory
Assembler messages:
Fatal error: can't create
build/board/spear/spear300/../common/spr_lowlevel_init.o: No such file or directory
The way i test MAKEALL is to define the BUILD_DIR to be something that is not
the source directory. Please rerun MAKEALL this way and resolve these errors.
I will do a more detailed review soon.
Tom
next prev parent reply other threads:[~2010-01-07 16:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 11:56 [U-Boot] [PATCH v2 0/9] Added support for SPEAr SoCs Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 1/9] Added README.spear Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 2/9] SPEAr600 SoC support added Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 3/9] SPEAr300 " Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 4/9] SPEAr310 " Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 5/9] SPEAr320 " Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 6/9] i2c driver support for SPEAr SoCs Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 7/9] smi " Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 8/9] nand(fsmc) " Vipin KUMAR
2010-01-07 11:56 ` [U-Boot] [PATCH v2 9/9] usbd " Vipin KUMAR
2010-01-09 9:50 ` Remy Bohmer
2010-01-07 16:42 ` Tom [this message]
2010-01-07 18:03 ` [U-Boot] [PATCH v2 0/9] Added " Armando VISCONTI
2010-01-08 13:28 ` Vipin KUMAR
2010-01-07 18:21 ` Peter Tyser
2010-01-08 4:35 ` Vipin KUMAR
2010-01-08 15:55 ` Peter Tyser
2010-01-08 16:43 ` Tom
2010-01-11 17:13 ` Vipin Kumar
2010-01-12 13:38 ` Tom
2010-01-08 13:31 ` Vipin KUMAR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B460ED8.5030101@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.