Re: [PATCH] omap: serial: fix coding style indentaion

[Nishanth Menon <nm@ti.com>]

Pandita, Vikram had written, on 01/07/2010 12:49 PM, the following:
> Just fix coding style indentaion as per checkpatch
> No logical code change.
> 
> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
> ---
>  arch/arm/mach-omap2/serial.c |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
> index 8c964be..467e5de 100644
> --- a/arch/arm/mach-omap2/serial.c
> +++ b/arch/arm/mach-omap2/serial.c
> @@ -694,15 +694,15 @@ void __init omap_serial_init_port(int port)
>  		DEV_CREATE_FILE(dev, &dev_attr_sleep_timeout);
>  	}
>  
> -		/* omap44xx: Never read empty UART fifo
> -		 * omap3xxx: Never read empty UART fifo on UARTs
> -		 * with IP rev >=0x52
> -		 */
> -		if (cpu_is_omap44xx())
> -			uart->p->serial_in = serial_in_override;
> -		else if ((serial_read_reg(uart->p, UART_OMAP_MVER) & 0xFF)
> -				>= UART_OMAP_NO_EMPTY_FIFO_READ_IP_REV)
> -			uart->p->serial_in = serial_in_override;
> +	/* omap44xx: Never read empty UART fifo
> +	 * omap3xxx: Never read empty UART fifo on UARTs
> +	 * with IP rev >=0x52
> +	 */
Since you are fixing the coding style, ;) multiline comment goes:
/*
  * tada tada
  */
Ref: Documentation/CodingStyle Chapter 8: Commenting

> +	if (cpu_is_omap44xx())
> +		uart->p->serial_in = serial_in_override;
> +	else if ((serial_read_reg(uart->p, UART_OMAP_MVER) & 0xFF)
> +			>= UART_OMAP_NO_EMPTY_FIFO_READ_IP_REV)
> +		uart->p->serial_in = serial_in_override;
>  }
>  
>  /**


-- 
Regards,
Nishanth Menon