From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] write option roms in pc-bios/
Date: Thu, 07 Jan 2010 14:03:08 -0600 [thread overview]
Message-ID: <4B463DFC.5040505@linux.vnet.ibm.com> (raw)
In-Reply-To: <1261664861-15493-1-git-send-email-pbonzini@redhat.com>
On 12/24/2009 08:27 AM, Paolo Bonzini wrote:
>>> The gdt address calculation in linuxboot.bin is broken in two ways: first
>>> it loads %cs into %eax, but that instruction leaves the high bits of %eax
>>> undefined and we did not clear them. Secondly, we completely ignore the
>>> incorrect %eax, and use the undefined %ebx instead.
>>>
>>> With these issues fixed, linuxboot works again.
>>>
>> Wow, I wonder how it worked for me...
>>
> Got it. The option roms are built in pc-bios/optionrom, but QEMU loads
> the ones in pc-bios. So actually I was always testing Alexander's code
> even though I had done a "make -B" to feel safer. :-(
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>
This will wreak havoc on the tree since these are built by default and
they are replacing files in revision control.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2010-01-07 20:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-24 13:38 [PATCH master, stable-0.12] linuxboot: fix gdt address calculation Avi Kivity
2009-12-24 13:56 ` Paolo Bonzini
[not found] ` <1261664861-15493-1-git-send-email-pbonzini@redhat.com>
2010-01-07 20:03 ` Anthony Liguori [this message]
2010-01-08 7:31 ` [Qemu-devel] Re: [PATCH] write option roms in pc-bios/ Paolo Bonzini
2010-01-08 7:57 ` Aurelien Jarno
2010-01-08 8:19 ` Paolo Bonzini
2010-01-08 9:12 ` Aurelien Jarno
2010-01-08 12:29 ` Anthony Liguori
2010-01-08 16:41 ` [Qemu-devel] [PATCH master, stable-0.12] linuxboot: fix gdt address calculation Anthony Liguori
2010-01-08 16:41 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B463DFC.5040505@linux.vnet.ibm.com \
--to=aliguori@linux.vnet.ibm.com \
--cc=avi@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.