From: "René Bolldorf" <xsecute@googlemail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH]drivers/ata/libata-eh.c:1509 unneeded memset()
Date: Thu, 07 Jan 2010 21:40:18 +0100 [thread overview]
Message-ID: <4B4646B2.6050103@googlemail.com> (raw)
In-Reply-To: <4B46453E.1060206@googlemail.com>
On 01/07/10 21:34, René Bolldorf wrote:
> On 01/07/10 20:15, Jeff Garzik wrote:
>> I need a little bit more detail than an unqualified statement... Did
>> you audit all paths leading to this code point?
>
> Yes, and my two systems running fine with the patch, no oops or panic's.
Sry forgot that:
/* initialize sense_buf with the error register,
* for the case where they are -not- overwritten
*/
sense_buf[0] = 0x70;
sense_buf[2] = dfl_sense_key;
So i think memset() is not needed and works very well without it.
next prev parent reply other threads:[~2010-01-07 20:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 22:59 [PATCH]drivers/ata/libata-eh.c:1509 unneeded memset() René Bolldorf
2010-01-07 19:15 ` Jeff Garzik
2010-01-07 20:34 ` René Bolldorf
2010-01-07 20:40 ` René Bolldorf [this message]
2010-01-08 11:30 ` Rolf Eike Beer
2010-01-08 15:28 ` James Bottomley
2010-01-08 20:47 ` René Bolldorf
2010-01-08 20:47 ` René Bolldorf
2010-01-08 22:21 ` Marc Bejarano
[not found] <5543f88f1001111129u362be554kd97027d977b5dff3@mail.gmail.com>
2010-01-11 19:41 ` Marc Bejarano
2010-01-11 20:18 ` René Bolldorf
2010-01-12 0:55 ` Marc Bejarano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4646B2.6050103@googlemail.com \
--to=xsecute@googlemail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.