From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [Patch 1/2] tabled: fix bugs in streaming of data Date: Thu, 07 Jan 2010 17:10:49 -0500 Message-ID: <4B465BE9.1060506@garzik.org> References: <20100105002749.4e13eb50@redhat.com> <4B4302C0.9080007@garzik.org> <20100105210255.74397f8c@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=kysiBErsaFyKlYFMFpRa6FYDQle6tjrmhCiWfgD0yjw=; b=vMNr039qam1WjG/mVLTCdv/2PZv0UoM5EM4a/cS0fdDgpESAiGv071+6UA55xhE0Ne s8Irn7u/mDB2yc3HWW2FLwM37FKCUhFa6mR87PQSul9m39xz9atwZcg8EKW2mHAuD3bj kMpyTdppgqxpVxliI8AdDyGB2eejC74eUVkp0= In-Reply-To: <20100105210255.74397f8c@redhat.com> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Pete Zaitcev Cc: Project Hail List On 01/05/2010 11:02 PM, Pete Zaitcev wrote: > On Tue, 05 Jan 2010 04:13:36 -0500 > Jeff Garzik wrote: > >> applied... chunkd needs these fixes also, yes? > > No, it appears correct as-is. Although, the large-object test in > the suite does not check the data it transmits, so if chunkd were > broken, we might not know it. On the other hand, the fact that > tabled stores test objects in chunkservers assures us that it > works at least as far as tabled's tests verify. I was thinking specifically that chunkd may want the in-progress xfer codes changes in your patch. chunkd, tabled, nfs4d (and ancient storaged) all share the same basic write-in-progress and TCP data xfer code. I'll take a look, no need to worry about it yourself. Jeff