All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3] sh: prepare the DMA driver for slave functionality
Date: Thu, 07 Jan 2010 23:03:21 +0000	[thread overview]
Message-ID: <4B466839.8010601@intel.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1001061538360.4366@axis700.grange>

Guennadi Liakhovetski wrote:
> Slightly clean up and prepare for slave DMA the shdma driver.

Please add some notes about the why/what of factoring out 
sh_dmae_prep_sg() and sh_dmae_add_desc() .  Reading this changelog I was 
expecting primarily simple cleanups, with maybe a few function renames.

Otherwise looks ok to me.

--
Dan


      reply	other threads:[~2010-01-07 23:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-06 16:12 [PATCH 1/3] sh: prepare the DMA driver for slave functionality Guennadi Liakhovetski
2010-01-07 23:03 ` Dan Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B466839.8010601@intel.com \
    --to=dan.j.williams@intel.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.