From: Emmanuel Kasper <emmanuel@libera.cc>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Use of LONG_LONG_MAX breaks build on OSX ?
Date: Fri, 08 Jan 2010 00:20:54 +0100 [thread overview]
Message-ID: <4B466C56.5020701@libera.cc> (raw)
Hello
Qemu does not build on my platform ( OSX / 10.5 / PowerPC ) because of
the use of LONG_LONG_MAX in raw-posix.c
Replacing LONG_LONG_MAX with LLONG_MAX fixes the build and is more
standard IMHO ( LONG_LONG_MAX is GNU libc, LLONG_MAX is C99 standard )
The following patch makes this trivial switch.
--- block-raw-posix.c.before 2010-01-07 22:40:37.000000000 +0100
+++ block-raw-posix.c 2010-01-07 22:41:43.000000000 +0100
@@ -782,7 +782,7 @@
if (size == 0)
#endif
#ifdef CONFIG_COCOA
- size = LONG_LONG_MAX;
+ size = LLONG_MAX;
#else
size = lseek(fd, 0LL, SEEK_END);
#endif
next reply other threads:[~2010-01-07 23:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 23:20 Emmanuel Kasper [this message]
2010-02-28 18:07 ` [Qemu-devel] Use of LONG_LONG_MAX breaks build on OSX ? Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B466C56.5020701@libera.cc \
--to=emmanuel@libera.cc \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.