From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miguel Aguilar Subject: Re: [PATCH 2/2] Davinci: DM365: Enable DaVinci Voice Codec support for DM365 EVM Date: Fri, 08 Jan 2010 11:36:59 -0600 Message-ID: <4B476D3B.3050200@ridgerun.com> References: <1262902641-14821-1-git-send-email-miguel.aguilar@ridgerun.com> <20100108113121.GB10128@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.navvo.net (mail.navvo.net [74.208.67.6]) by alsa0.perex.cz (Postfix) with ESMTP id BA1E410384D for ; Fri, 8 Jan 2010 18:37:43 +0100 (CET) In-Reply-To: <20100108113121.GB10128@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: davinci-linux-open-source@linux.davincidsp.com, clark.becker@ridgerun.com, santiago.nunez@ridgerun.com, diego.dompe@ridgerun.com, alsa-devel@alsa-project.org, nsnehaprabha@ti.com, todd.fischer@ridgerun.com List-Id: alsa-devel@alsa-project.org Mark Brown wrote: > On Thu, Jan 07, 2010 at 04:17:21PM -0600, miguel.aguilar@ridgerun.com wrote: > >> + if (device == 0) >> + davinci_cfg_reg(DM365_EVT2_ASP_TX); >> + else >> + davinci_cfg_reg(DM365_EVT2_VC_TX); > > I'd be a bit more comfortable with this if it were using something more > symbolic like a #define or enum rather than checking a bare number to > work out which device it's talking to. > > Otherwise this looks good, but I've no familiarity with DaVinci > specifics so... The idea of these function is check at runtime if the user space application is requesting the AIC3x or the voice codec, then it will set the proper source for the dma channels, since the ASP and the Voice Codec share the same dma channels, so that's why use a #define doesn't make sense. Can you check the part of this patch related to registering both codecs AIC3x and the voice codec? Thank you, Miguel Aguilar