From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Sun, 10 Jan 2010 12:22:28 +0000 Subject: Re: [PATCH 1/2] KVM: PPC: Pass through program interrupts Message-Id: <4B49C684.8080407@redhat.com> List-Id: References: <1263090452-30439-1-git-send-email-agraf@suse.de> In-Reply-To: <1263090452-30439-1-git-send-email-agraf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: kvm@vger.kernel.org, kvm-ppc On 01/10/2010 04:27 AM, Alexander Graf wrote: > When we get a program interrupt in guest kernel mode, we try to emulate the > instruction. > > If that doesn't fail, we report to the user and try again - at the exact same > instruction pointer. So if the guest kernel really does trigger an invalid > instruction, we loop forever. > > So let's better go and forward program exceptions to the guest when we don't > know the instruction we're supposed to emulate. > > Applied both, and queued for .33. I was able to guess this from the description, but please mention it explicitly in the future. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] KVM: PPC: Pass through program interrupts Date: Sun, 10 Jan 2010 14:22:28 +0200 Message-ID: <4B49C684.8080407@redhat.com> References: <1263090452-30439-1-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, kvm-ppc To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59481 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750834Ab0AJMWg (ORCPT ); Sun, 10 Jan 2010 07:22:36 -0500 In-Reply-To: <1263090452-30439-1-git-send-email-agraf@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 01/10/2010 04:27 AM, Alexander Graf wrote: > When we get a program interrupt in guest kernel mode, we try to emulate the > instruction. > > If that doesn't fail, we report to the user and try again - at the exact same > instruction pointer. So if the guest kernel really does trigger an invalid > instruction, we loop forever. > > So let's better go and forward program exceptions to the guest when we don't > know the instruction we're supposed to emulate. > > Applied both, and queued for .33. I was able to guess this from the description, but please mention it explicitly in the future. -- error compiling committee.c: too many arguments to function