From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Sun, 10 Jan 2010 14:26:25 +0000 Subject: Re: [PATCH 1/2] KVM: PPC: Pass through program interrupts Message-Id: <4B49E391.60108@redhat.com> List-Id: References: <1263090452-30439-1-git-send-email-agraf@suse.de> <4B49C684.8080407@redhat.com> In-Reply-To: <4B49C684.8080407-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc On 01/10/2010 02:22 PM, Avi Kivity wrote: > On 01/10/2010 04:27 AM, Alexander Graf wrote: >> When we get a program interrupt in guest kernel mode, we try to >> emulate the >> instruction. >> >> If that doesn't fail, we report to the user and try again - at the >> exact same >> instruction pointer. So if the guest kernel really does trigger an >> invalid >> instruction, we loop forever. >> >> So let's better go and forward program exceptions to the guest when >> we don't >> know the instruction we're supposed to emulate. >> > > Applied both, and queued for .33. I was able to guess this from the > description, but please mention it explicitly in the future. > I get this building ppc32: scripts/kconfig/conf -s arch/powerpc/Kconfig CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh :1523:2: warning: #warning syscall recvmmsg not implemented CC arch/powerpc/kvm/emulate.o arch/powerpc/kvm/emulate.c: In function 'kvmppc_emulate_instruction': arch/powerpc/kvm/emulate.c:467: error: too many arguments to function 'kvmppc_core_queue_program' make[1]: *** [arch/powerpc/kvm/emulate.o] Error 1 -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] KVM: PPC: Pass through program interrupts Date: Sun, 10 Jan 2010 16:26:25 +0200 Message-ID: <4B49E391.60108@redhat.com> References: <1263090452-30439-1-git-send-email-agraf@suse.de> <4B49C684.8080407@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc To: Alexander Graf Return-path: In-Reply-To: <4B49C684.8080407-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On 01/10/2010 02:22 PM, Avi Kivity wrote: > On 01/10/2010 04:27 AM, Alexander Graf wrote: >> When we get a program interrupt in guest kernel mode, we try to >> emulate the >> instruction. >> >> If that doesn't fail, we report to the user and try again - at the >> exact same >> instruction pointer. So if the guest kernel really does trigger an >> invalid >> instruction, we loop forever. >> >> So let's better go and forward program exceptions to the guest when >> we don't >> know the instruction we're supposed to emulate. >> > > Applied both, and queued for .33. I was able to guess this from the > description, but please mention it explicitly in the future. > I get this building ppc32: scripts/kconfig/conf -s arch/powerpc/Kconfig CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh :1523:2: warning: #warning syscall recvmmsg not implemented CC arch/powerpc/kvm/emulate.o arch/powerpc/kvm/emulate.c: In function 'kvmppc_emulate_instruction': arch/powerpc/kvm/emulate.c:467: error: too many arguments to function 'kvmppc_core_queue_program' make[1]: *** [arch/powerpc/kvm/emulate.o] Error 1 -- error compiling committee.c: too many arguments to function