Re: [PATCH 2/4] mm/page_alloc : relieve the zone->lock's pressure for allocation

[Huang Shijie <shijie8@gmail.com>]

>>    The __mod_zone_page_state() only require irq disabling,
>> it does not require the zone's spinlock. So move it out of
>> the guard region of the spinlock to relieve the pressure for
>> allocation.
>>
>> Signed-off-by: Huang Shijie<shijie8@gmail.com>
>> ---
>>   mm/page_alloc.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 23df1ed..00aa83a 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -961,8 +961,8 @@ static int rmqueue_single(struct zone *zone, unsigned long count,
>>   		set_page_private(page, migratetype);
>>   		list =&page->lru;
>>   	}
>> -	__mod_zone_page_state(zone, NR_FREE_PAGES, -i);
>>   	spin_unlock(&zone->lock);
>> +	__mod_zone_page_state(zone, NR_FREE_PAGES, -i);
>>   	return i;
>>   }
>>
>> -- 
>> 1.6.5.2
>>
>>      
> How about moving this patch into [4/4]?
> Otherwise, Looks good to me.
>
>    
I just  want to make the patches  more clear : two for memory 
allocation, two for memory free.

> Reviewed-by: Minchan Kim<minchan.kim@gmail.com>
>
>    
thanks a lot.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>