From: Tejun Heo <tj@kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Mikael Pettersson <mikpe@it.uu.se>, linux-ide@vger.kernel.org
Subject: Re: 2.6.33-rc2 pata_macio fails to detect PMac G3 CD-drive
Date: Mon, 11 Jan 2010 16:01:49 +0900 [thread overview]
Message-ID: <4B4ACCDD.8040803@kernel.org> (raw)
In-Reply-To: <1263186759.724.132.camel@pasglop>
Hello,
On 01/11/2010 02:12 PM, Benjamin Herrenschmidt wrote:
> Tejun, what's your take here ? It looks like reading the status reg
> is not enough to bring the interrupt down. We could try to disable_irq
> in freeze() (we know we don't share interrupts in the case of macio)
> and re-enable it right after firing off the first taskfile maybe ?
It would be best if the controller has an IRQ pending bit and IRQ can
be cleared as spurious on those bogus interrupts. The reason why SFF
IDE interface is so prone to IRQ storm is because there's no way the
driver can tell whether the controller is raising interrupt or not.
Does the controller have a way to clear IRQ other than reading the
status reg?
Thanks.
--
tejun
next prev parent reply other threads:[~2010-01-11 6:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-26 17:18 2.6.33-rc2 pata_macio fails to detect PMac G3 CD-drive Mikael Pettersson
2009-12-26 20:52 ` Benjamin Herrenschmidt
2010-01-11 5:12 ` Benjamin Herrenschmidt
2010-01-11 7:01 ` Tejun Heo [this message]
2010-01-11 9:41 ` Benjamin Herrenschmidt
2010-01-12 0:35 ` Tejun Heo
2010-01-12 0:35 ` Benjamin Herrenschmidt
2010-01-13 13:15 ` Mikael Pettersson
2010-01-13 19:58 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4ACCDD.8040803@kernel.org \
--to=tj@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.