From: Patrick McHardy <kaber@trash.net>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
"Pekka Savola (ipv6)" <pekkas@netcore.fi>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Remove (*mangle[]) array and functions, use %pI4
Date: Mon, 11 Jan 2010 11:51:42 +0100 [thread overview]
Message-ID: <4B4B02BE.5060209@trash.net> (raw)
In-Reply-To: <1262805798.1952.105.camel@Joe-Laptop.home>
Joe Perches wrote:
> These functions merely exist to format a buffer and call
> nf_nat_mangle_tcp_packet.
>
> Format the buffer and perform the call in nf_nat_ftp instead.
>
> Use %pI4 for the IP address.
>
> Saves ~600 bytes of text
>
> old:
> $ size net/ipv4/netfilter/nf_nat_ftp.o
> text data bss dec hex filename
> 2187 160 408 2755 ac3 net/ipv4/netfilter/nf_nat_ftp.o
> new:
> $ size net/ipv4/netfilter/nf_nat_ftp.o
> text data bss dec hex filename
> 1532 112 288 1932 78c net/ipv4/netfilter/nf_nat_ftp.o
Applied, thanks. BTW, its enough to CC netfilter-devel and optionally
netdev on patches, netfilter and netfilter-core are unnecessary.
next prev parent reply other threads:[~2010-01-11 10:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 1:20 [PATCH 0/8] Remove most uses of NIPQUAD and NIPQUAD_FMT Joe Perches
2010-01-06 1:20 ` Joe Perches
2010-01-06 1:20 ` [Ocfs2-devel] " Joe Perches
2010-01-06 1:20 ` [PATCH 1/8] drivers/scsi: Remove uses of NIPQUAD, use %pI4 Joe Perches
2010-01-06 1:20 ` [PATCH 2/8] drivers/staging/pohmelfs/inode.c: " Joe Perches
2010-01-06 1:20 ` [PATCH 3/8] net/rds: " Joe Perches
2010-01-06 1:20 ` [PATCH 4/8] net/sunrpc: " Joe Perches
2010-01-06 1:20 ` Joe Perches
2010-01-06 1:20 ` [PATCH 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Convert NIPQUAD to %pI4 Joe Perches
2010-01-06 19:23 ` [PATCH v2 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Remove (*mangle[]) array and functions, use %pI4 Joe Perches
2010-01-11 10:51 ` Patrick McHardy [this message]
2010-01-11 11:09 ` [PATCH] MAINTAINERS: netfilter - Remove netfilter and netfilter-core lists Joe Perches
2010-01-11 11:14 ` Patrick McHardy
2010-01-11 11:27 ` [PATCH V2] MAINTAINERS: netfilter - Document netfilter and netfilter-core lists purposes Joe Perches
2010-01-11 11:31 ` Jan Engelhardt
2010-01-11 11:43 ` Joe Perches
2010-01-12 18:46 ` [PATCH V3] MAINTAINERS: Document list types, add "A:" section type, update NETFILTER Joe Perches
2010-01-13 15:13 ` Stefan Richter
2010-01-13 16:15 ` Joe Perches
2010-01-13 17:10 ` Stefan Richter
2010-01-15 20:03 ` Pavel Machek
2010-01-06 1:20 ` [PATCH 6/8] net/netfilter/ipvs/ip_vs_ftp.c: Use standardized format in sprintf Joe Perches
2010-01-06 2:34 ` Simon Horman
2010-01-11 10:54 ` Patrick McHardy
2010-01-06 1:20 ` [Ocfs2-devel] [PATCH 7/8] fs/ocfs2/cluster/tcp.c: Remove use of NIPQUAD, use %pI4 Joe Perches
2010-01-06 1:20 ` Joe Perches
2010-01-07 1:51 ` [Ocfs2-devel] " Joel Becker
2010-01-07 1:51 ` Joel Becker
2010-01-06 1:20 ` [PATCH 8/8] drivers/firmware/iscsi_ibft.c: Remove NIPQUAD_FMT, " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4B02BE.5060209@trash.net \
--to=kaber@trash.net \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.