From: Mike Rapoport <mike@compulab.co.il>
To: Anuj Aggarwal <anuj.aggarwal@ti.com>
Cc: linux-omap@vger.kernel.org, broonie@opensource.wolfsonmicro.com,
lrg@slimlogic.co.uk
Subject: Re: [PATCH 6/6] Regulator: Makefile modified to include TWL4030-PMIC specific file
Date: Mon, 11 Jan 2010 13:43:55 +0200 [thread overview]
Message-ID: <4B4B0EFB.5050008@compulab.co.il> (raw)
In-Reply-To: <1262973498-32685-1-git-send-email-anuj.aggarwal@ti.com>
Anuj Aggarwal wrote:
> Makefile is modified so that board-omap35x-twl4030-pmic.c gets compiled
> for the platforms having TWL4030 as the PMIC.
>
> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
> ---
> arch/arm/mach-omap2/Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Can you combine this patch with "Modifying Kconfig to choose from the
available PMICs" patch?
Moreover, I think the patches should be reordered so that kernel build
won't be broken. Maybe something like:
1 - Creating TWL4030 specific file having supplies & init data
2 - Modifying Kconfig and Makefile to choose from the available PMICs
3 - Kconfig modified to select TWL4030 for OMAP3 based platforms
4 - Use common regulator supplies and init data structs
> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> index b32678b..181be39 100644
> --- a/arch/arm/mach-omap2/Makefile
> +++ b/arch/arm/mach-omap2/Makefile
> @@ -107,6 +107,7 @@ obj-$(CONFIG_MACH_IGEP0020) += board-igep0020.o \
> mmc-twl4030.o
> obj-$(CONFIG_MACH_OMAP3_TOUCHBOOK) += board-omap3touchbook.o \
> mmc-twl4030.o
> +obj-$(CONFIG_PMIC_TWL4030) += board-omap35x-twl4030-pmic.o
> obj-$(CONFIG_MACH_OMAP_4430SDP) += board-4430sdp.o
>
> obj-$(CONFIG_MACH_OMAP3517EVM) += board-am3517evm.o
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2010-01-11 11:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 17:58 [PATCH 6/6] Regulator: Makefile modified to include TWL4030-PMIC specific file Anuj Aggarwal
2010-01-11 11:43 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4B0EFB.5050008@compulab.co.il \
--to=mike@compulab.co.il \
--cc=anuj.aggarwal@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.