From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] use pkg-config for sdl when cross compiling
Date: Mon, 11 Jan 2010 13:40:18 -0600 [thread overview]
Message-ID: <4B4B7EA2.2030501@codemonkey.ws> (raw)
In-Reply-To: <1262875338-4104-3-git-send-email-pbonzini@redhat.com>
On 01/07/2010 08:42 AM, Paolo Bonzini wrote:
> Together with the previous patch this enables using the prefixed
> pkg-config, thus picking up the correct flags for SDL. Since
> pkg-config has an awful lot of dependencies, I still use sdl-config
> when not cross-compiling since some people may only have the latter.
>
Wouldn't it make more sense to try to use pkg-config always and if it's
not available, fall back on sdl-config?
That means we don't have a separate code path for cross compiling which
means it's less likely to break.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2010-01-11 19:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 14:42 [Qemu-devel] [PATCH 0/3] Fixes for Linux->Win32 cross-compilation Paolo Bonzini
2010-01-07 14:42 ` [Qemu-devel] [PATCH 1/3] use cross-prefix for pkg-config Paolo Bonzini
2010-01-07 14:42 ` [Qemu-devel] [PATCH 2/3] use pkg-config for sdl when cross compiling Paolo Bonzini
2010-01-11 19:40 ` Anthony Liguori [this message]
2010-01-12 8:46 ` Paolo Bonzini
2010-01-12 15:03 ` Anthony Liguori
2010-01-07 14:42 ` [Qemu-devel] [PATCH 3/3] use pkg-config for libcurl " Paolo Bonzini
2010-01-07 15:23 ` [Qemu-devel] [PATCH 0/3] Fixes for Linux->Win32 cross-compilation Stefan Weil
2010-01-07 18:28 ` [Qemu-devel] " Paolo Bonzini
2010-01-07 19:46 ` Anthony Liguori
2010-01-08 7:27 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4B7EA2.2030501@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.