All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: aliguori@us.ibm.com, yvugenfi@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-pci: thinko fix
Date: Mon, 11 Jan 2010 13:47:06 -0600	[thread overview]
Message-ID: <4B4B803A.2060507@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100111155739.GA8588@redhat.com>

On 01/11/2010 09:57 AM, Michael S. Tsirkin wrote:
> Since patch ed757e140c0ada220f213036e4497315d24ca8bct, virtio will
> sometimes clear all status registers on bus master disable, which loses
> information such as VIRTIO_CONFIG_S_FAILED bit.  This is a result of
> a patch being misapplied: code uses !  instead of ~ for bit
> operations as in Yan's original patch.  This obviously does not make
> sense.
>    

Actually, the original patch used '!'.  It didn't carry a Signed-off-by 
and when it was reposted with a SoB, this was changed to '~'.  There was 
no indication though that the contents of the patch was different.

Moral of the story is, when you make a change to the patch, add a (v2) 
and state in the commit message what change was made.

Thanks for catching this.

Regards,

Anthony Liguori

      reply	other threads:[~2010-01-11 19:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-11 15:57 [Qemu-devel] [PATCH] virtio-pci: thinko fix Michael S. Tsirkin
2010-01-11 19:47 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B4B803A.2060507@linux.vnet.ibm.com \
    --to=aliguori@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yvugenfi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.