From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NUQbp-0000aL-CT
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 15:11:29 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NUQbo-0000Zy-7j
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 15:11:28 -0500
Received: from [199.232.76.173] (port=45117 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NUQbn-0000Zv-Vg
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 15:11:28 -0500
Received: from are.twiddle.net ([75.149.56.221]:35778)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rth@twiddle.net>) id 1NUQbn-00015Q-HL
	for qemu-devel@nongnu.org; Mon, 11 Jan 2010 15:11:27 -0500
Message-ID: <4B4B85ED.5080001@twiddle.net>
Date: Mon, 11 Jan 2010 12:11:25 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/5] tcg-sparc: Implement division properly.
References: <cover.1263237726.git.rth@twiddle.net>
	<89dafaffa4df925094d2d43acc985cb040d6161c.1263237726.git.rth@twiddle.net>
In-Reply-To: <89dafaffa4df925094d2d43acc985cb040d6161c.1263237726.git.rth@twiddle.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: blauwirbel@gmail.com

On 01/11/2010 11:09 AM, Richard Henderson wrote:
> +    /* Load Y with the sign/zero extension of RS1 to 64-bits.  */
> +    if (uns) {
> +        tcg_out_sety(s, TCG_REG_G0);
> +    } else {
> +        tcg_out_arith(s, TCG_REG_I5, rs1, 31, SHIFT_SRA);

Bah.  tcg_out_arithi.

Programming by code inspection only sucks.


r~