From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf Date: Mon, 11 Jan 2010 21:40:52 +0100 Message-ID: <4B4B8CD4.8090505@web.de> References: <20100107124449.GY4905@redhat.com> <20100107162427.GF4905@redhat.com> <4B4B7988.5090803@codemonkey.ws> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigBE0F615B883215C083DB3294" Cc: Gleb Natapov , qemu-devel@nongnu.org, kvm-devel , Avi Kivity , Marcelo Tosatti To: Anthony Liguori Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:35864 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753211Ab0AKUuP (ORCPT ); Mon, 11 Jan 2010 15:50:15 -0500 In-Reply-To: <4B4B7988.5090803@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigBE0F615B883215C083DB3294 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Anthony Liguori wrote: > On 01/07/2010 10:24 AM, Gleb Natapov wrote: >> diff --git a/target-i386/kvm.c b/target-i386/kvm.c >> index 4084503..6a841de 100644 >> --- a/target-i386/kvm.c >> +++ b/target-i386/kvm.c >> @@ -17,6 +17,7 @@ >> #include >> >> #include >> +#include >=20 > This breaks the build on a default F12 install because while kvm.h is > present, kvm_para.h is not. This is a hard one to fix. >=20 > We can default the kvm search path to /lib/modules/$(uname -r)/build, w= e > can fix the glibc headers and live with it, or we can pull in the kvm > headers into qemu. >=20 > Avi/Marcelo/Jan, any thoughts from the qemu-kvm side? kvm-kmod-wise, I can include arch and generic kvm_para.h in the next release (missed the need for it so far). I'm planning to write a qemu patch to ask pkg-config for kvm-kmod headers. If we can live with considering the cpuid leaf a feature that depends on a recent kvm-kmod version and is disabled otherwise, we are done. If not, tricks like the above are required. Jan --------------enigBE0F615B883215C083DB3294 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAktLjNcACgkQitSsb3rl5xSJGgCfasC91w4epskD1EIiqOolx2+Y xmUAnRye1KTSD2O6O2baP+rdouqhep/7 =3IJE -----END PGP SIGNATURE----- --------------enigBE0F615B883215C083DB3294-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NURDS-000636-0c for qemu-devel@nongnu.org; Mon, 11 Jan 2010 15:50:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NURDO-0005uR-1Z for qemu-devel@nongnu.org; Mon, 11 Jan 2010 15:50:21 -0500 Received: from [199.232.76.173] (port=33957 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NURDN-0005uE-Km for qemu-devel@nongnu.org; Mon, 11 Jan 2010 15:50:17 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:35866) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NURDN-0003Vn-2X for qemu-devel@nongnu.org; Mon, 11 Jan 2010 15:50:17 -0500 Message-ID: <4B4B8CD4.8090505@web.de> Date: Mon, 11 Jan 2010 21:40:52 +0100 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf References: <20100107124449.GY4905@redhat.com> <20100107162427.GF4905@redhat.com> <4B4B7988.5090803@codemonkey.ws> In-Reply-To: <4B4B7988.5090803@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigBE0F615B883215C083DB3294" Sender: jan.kiszka@web.de List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Avi Kivity , Marcelo Tosatti , qemu-devel@nongnu.org, Gleb Natapov , kvm-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigBE0F615B883215C083DB3294 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Anthony Liguori wrote: > On 01/07/2010 10:24 AM, Gleb Natapov wrote: >> diff --git a/target-i386/kvm.c b/target-i386/kvm.c >> index 4084503..6a841de 100644 >> --- a/target-i386/kvm.c >> +++ b/target-i386/kvm.c >> @@ -17,6 +17,7 @@ >> #include >> >> #include >> +#include >=20 > This breaks the build on a default F12 install because while kvm.h is > present, kvm_para.h is not. This is a hard one to fix. >=20 > We can default the kvm search path to /lib/modules/$(uname -r)/build, w= e > can fix the glibc headers and live with it, or we can pull in the kvm > headers into qemu. >=20 > Avi/Marcelo/Jan, any thoughts from the qemu-kvm side? kvm-kmod-wise, I can include arch and generic kvm_para.h in the next release (missed the need for it so far). I'm planning to write a qemu patch to ask pkg-config for kvm-kmod headers. If we can live with considering the cpuid leaf a feature that depends on a recent kvm-kmod version and is disabled otherwise, we are done. If not, tricks like the above are required. Jan --------------enigBE0F615B883215C083DB3294 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAktLjNcACgkQitSsb3rl5xSJGgCfasC91w4epskD1EIiqOolx2+Y xmUAnRye1KTSD2O6O2baP+rdouqhep/7 =3IJE -----END PGP SIGNATURE----- --------------enigBE0F615B883215C083DB3294--