From: Jeff Garzik <jeff@garzik.org>
To: Colin McCabe <cmccabe@alumni.cmu.edu>
Cc: Project Hail List <hail-devel@vger.kernel.org>,
Pete Zaitcev <zaitcev@redhat.com>
Subject: Re: [PATCH] tabled: use LL to indicate 64-bit constant
Date: Mon, 11 Jan 2010 21:51:26 -0500 [thread overview]
Message-ID: <4B4BE3AE.6080107@garzik.org> (raw)
In-Reply-To: <1263129012-29423-1-git-send-email-cmccabe@alumni.cmu.edu>
On 01/10/2010 08:10 AM, Colin McCabe wrote:
> All integer constants are squashed into ints (i.e. 32-bit) unless you specify
> otherwise.
>
> Signed-off-by: Colin McCabe<cmccabe@alumni.cmu.edu>
> ---
> server/util.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/server/util.c b/server/util.c
> index 3c15123..63a3acb 100644
> --- a/server/util.c
> +++ b/server/util.c
> @@ -328,7 +328,7 @@ int objid_init(uint64_t *obj_count, struct tabledb *tdbp)
> exit(1); /* Quit before something unknown blows up. */
> }
>
> - if (objcount& 0xff00000000000000) {
> + if (objcount& 0xff00000000000000ll) {
hmmm, I thought it was type-promoted as needed. I will check C99 when
I've had some sleep :)
next prev parent reply other threads:[~2010-01-12 2:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-10 13:10 [PATCH] tabled: use LL to indicate 64-bit constant Colin McCabe
2010-01-12 2:51 ` Jeff Garzik [this message]
2010-01-12 14:29 ` Jeff Garzik
2010-01-12 18:25 ` Colin McCabe
2010-01-12 19:24 ` Jeff Garzik
2010-01-12 19:57 ` Colin McCabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4BE3AE.6080107@garzik.org \
--to=jeff@garzik.org \
--cc=cmccabe@alumni.cmu.edu \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.