From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH 2/6] chunkd: change the prefix length of object pathname
 from 4 to 3
Date: Mon, 11 Jan 2010 21:55:39 -0500
Message-ID: <4B4BE4AB.4040501@garzik.org>
References: <1263212721-11210-1-git-send-email-akinobu.mita@gmail.com> <1263212721-11210-2-git-send-email-akinobu.mita@gmail.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=0WSAASNHlR0US9iAqDheoYeXiO3mQh5O+4oEUHiWuYo=;
        b=EPB06GFnEhi2OniStW4b7KP/qsGhzuJdzIj+QcaE4l/anUqaDnI7ha/AAJ6q1QOgOJ
         HfoURRDcIujRG9CL9egKPdPnaYjUdrF2TzMXg+UcgHbhQCC1RSCEoySF7USaHKFrGXfG
         bLve8lWrXI04+h+24rQfrtUGWSNzD5HWycHIc=
In-Reply-To: <1263212721-11210-2-git-send-email-akinobu.mita@gmail.com>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: hail-devel@vger.kernel.org

On 01/11/2010 07:25 AM, Akinobu Mita wrote:
> The volume directory may have 2^16 (=65536) directories because
> prefix length of object pathname is 4 bytes. But ext3 filesystem can
> only have EXT_LINK_MAX (32000) directories.
>
> This changes the prefix length from 4 bytes to 3 bytes and breaks
> the volume data format compatibility with older version.
>
> Now the maximum count of links in volume directory is 2^12 (=4096)
> and it doesn't exceed ext3's upper limit of max links.
>
> Signed-off-by: Akinobu Mita<akinobu.mita@gmail.com>
> ---
>   server/be-fs.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)

hey, welcome, new contributor!

This patch makes sense, but it also raises the question of whether or 
not we should move to a two-level directory scheme, eg.

	123/456/7890ABCDEF
     rather than
	123/4567890ABCDEF

to limit the size of the top-level directories.  It really depends on 
the object counts a typical chunkd node will be seeing.  As with the 
other patch, I will give this some thought after sleep.

Comments welcome!

	Jeff