From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [PATCH version2] libfs: Open code simple_commit_write into only
 user
Date: Tue, 12 Jan 2010 15:18:15 +0200
Message-ID: <4B4C7697.1080806@panasas.com>
References: <4B3B7473.4010403@panasas.com> <4B4C758B.9040605@panasas.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Randy Dunlap <randy.dunlap@oracle.com>
To: Al Viro <viro@ZenIV.linux.org.uk>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from daytona.panasas.com ([67.152.220.89]:18913 "EHLO
	daytona.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1751755Ab0ALNSR (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 12 Jan 2010 08:18:17 -0500
In-Reply-To: <4B4C758B.9040605@panasas.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 01/12/2010 03:13 PM, Boaz Harrosh wrote:
> 
> * simple_commit_write was only called by simple_write_end.
>   Open coding it makes it tiny bit less heavy on the arithmetic and
>   much more readable.
> 
> * While at it use zero_user() for clearing a partial page.
> * While at it add a docbook comment for simple_write_end.
> 
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
> ---

Al should I do the same for simple_prepare_write()?

It is EXPORT_UNUSED_SYMBOL() now, could I remove that
export?

Boaz