From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] tabled: use LL to indicate 64-bit constant Date: Tue, 12 Jan 2010 09:29:14 -0500 Message-ID: <4B4C873A.6050801@garzik.org> References: <1263129012-29423-1-git-send-email-cmccabe@alumni.cmu.edu> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=/+aTMSllFKmVakycXqKEPzuKbBJf90z1aXo3bV5bwNg=; b=bNTEXjE7GFbI/MnEb3qpay8ljZpwDfgWG/KUXeMOqDv8npRxVo9bcr6JJWgOOAVyT1 UpIb1ljLWsfrzLoOt0ss1p9jJ98oZJbl1REk4qIodCNcMTcJLjhkVbdHeWzhtvbQwZht NnI+Jp5RQMSzT4g3dz87ip5/sTqUcesGumFDQ= In-Reply-To: <1263129012-29423-1-git-send-email-cmccabe@alumni.cmu.edu> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Colin McCabe Cc: Project Hail List , Pete Zaitcev On 01/10/2010 08:10 AM, Colin McCabe wrote: > All integer constants are squashed into ints (i.e. 32-bit) unless you specify > otherwise. > > Signed-off-by: Colin McCabe > --- > server/util.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/server/util.c b/server/util.c > index 3c15123..63a3acb 100644 > --- a/server/util.c > +++ b/server/util.c > @@ -328,7 +328,7 @@ int objid_init(uint64_t *obj_count, struct tabledb *tdbp) > exit(1); /* Quit before something unknown blows up. */ > } > > - if (objcount& 0xff00000000000000) { > + if (objcount& 0xff00000000000000ll) { > applog(LOG_ERR, "Dangerous objid %llX\n", Yep, "The type of an integer constant is the first of the corresponding list in which its value can be represented." (C99 6.4.4.1 paragraph 5) Were you seeing a problem here? Jeff