From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NUkCZ-0003ba-8f
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 12:06:43 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NUkCU-0003Wg-Bi
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 12:06:42 -0500
Received: from [199.232.76.173] (port=59831 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NUkCT-0003WL-C7
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 12:06:37 -0500
Received: from mx20.gnu.org ([199.232.41.8]:14926)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <kraxel@redhat.com>) id 1NUkCQ-0001Ma-Pw
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 12:06:37 -0500
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NUkC9-0003Wf-MV
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 12:06:17 -0500
Message-ID: <4B4CABF2.5050204@redhat.com>
Date: Tue, 12 Jan 2010 18:05:54 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <cover.1263124239.git.mst@redhat.com>
	<20100110115253.GD27013@redhat.com>
In-Reply-To: <20100110115253.GD27013@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCHv7 3/3] virtio: add features as qdev
	properties
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

   Hi,

> +#define DEFINE_VIRTIO_NET_FEATURES(_state, _field) \
> +        DEFINE_VIRTIO_COMMON_FEATURES(_state, _field), \
> +        DEFINE_PROP_BIT("csum", _state, _field, VIRTIO_NET_F_CSUM, true), \
> +        DEFINE_PROP_BIT("guest_csum", _state, _field, VIRTIO_NET_F_GUEST_CSUM, true), \
> +        DEFINE_PROP_BIT("mac", _state, _field, VIRTIO_NET_F_MAC, true), \

Didn't noticed in review, sorry.  This isn't going to work as all 
network cards already have a 'mac' property to set the mac address.  Try 
to create a virtio nic with a non-default mac address and watch qemu fail.

cheers,
   Gerd